[
https://issues.apache.org/jira/browse/HADOOP-10568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13988187#comment-13988187
]
Aaron T. Myers commented on HADOOP-10568:
-----------------------------------------
Hello Mr. Wang, the patch looks pretty good to me. Two little comments for you,
+1 once these are addressed:
# It's best practice to document this option in the core-default.xml file, even
if you're not setting a default value. The description of the config setting in
that file will be helpful for users to know what the use of this option is and
the possible values they could set it to.
# Have you tested this when setting _no_ value for the encryption config
setting? i.e. is it definitely the case that passing {{null}} for this value
(as would be returned from {{Configuration#get(String)}} if this value is
unset) will work just fine? Or more generally, can you comment as to what
testing you've done of this patch?
Regarding the branch-2 patch, if the updated patch applies cleanly to branch-2
(as this patch does) then there's no need to post a separate patch.
> Add s3 server-side encryption
> -----------------------------
>
> Key: HADOOP-10568
> URL: https://issues.apache.org/jira/browse/HADOOP-10568
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs/s3
> Affects Versions: 2.4.0
> Reporter: David S. Wang
> Assignee: David S. Wang
> Labels: s3
> Attachments: HADOOP-10568.patch
>
>
> Add s3 server-side encryption as described here:
> http://docs.aws.amazon.com/AmazonS3/latest/dev/SSEUsingJavaSDK.html
--
This message was sent by Atlassian JIRA
(v6.2#6252)
