[
https://issues.apache.org/jira/browse/HADOOP-10567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13988012#comment-13988012
]
Chris Nauroth commented on HADOOP-10567:
----------------------------------------
Hi, [~hitliuyi]. +1 for this patch overall. Nice improvement on those tests
too.
I have a minor suggestion on the JavaDocs. Currently, the patch has this:
{code}
/*
* The value of <code>XAttr</code> is byte[], this class is to
* covert it to some kind of string representation.
* String representation is convenient For display and input. For example
* display in screen as shell response and json response, input as http
* or shell parameter.
*/
{code}
The logic here implements both encoding (bytes -> string) and decoding (string
-> bytes), so ideally the JavaDocs would mention both. Also, there is a small
typo in the third line. The first "For" should not be capitalized.
> Shift XAttr value encoding code out for reuse.
> ----------------------------------------------
>
> Key: HADOOP-10567
> URL: https://issues.apache.org/jira/browse/HADOOP-10567
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: HDFS XAttrs (HDFS-2006)
> Reporter: Yi Liu
> Assignee: Yi Liu
> Priority: Minor
> Fix For: HDFS XAttrs (HDFS-2006)
>
> Attachments: HADOOP-10567.patch
>
>
> XAttr value encoding(encode byte[] to string, hex string or base64 string for
> better display and input) is common, can be reused. It can be used by
> FsShell, in http request as parameter and json response.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
