[ 
https://issues.apache.org/jira/browse/HADOOP-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13977488#comment-13977488
 ] 

Andrew Wang commented on HADOOP-10531:
--------------------------------------

Hi [~sbarrier], I looked at this and agree that it's a typo and that your 
proposed fix works. Could you make a diff from the project root (name it 
something like "hadoop-10531-1.patch") and attach it to this JIRA? I'll then +1 
and commit it.

A lot of work I know for a 1-character patch, but that's our process :)

> hadoop-config.sh - bug in --hosts argument
> ------------------------------------------
>
>                 Key: HADOOP-10531
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10531
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.4.0
>         Environment: Linux
>            Reporter: Sebastien Barrier
>              Labels: patch
>
> I think there's a typo in the hadoop-config.sh which broke slave start in 
> cluster mode.
> To reproduce it :
> /usr/local/hadoop/sbin/hadoop-daemons.sh --config /etc/hadoop/conf --hosts 
> slaves start datanode
> here's the patch :
> --- hadoop-dist/target/hadoop-2.4.0/libexec/hadoop-config.sh    2014-04-22 
> 12:20:45.000000000 -0400
> +++ hadoop-dist/target/hadoop-2.4.0/libexec/hadoop-config.sh    2014-04-22 
> 12:21:00.000000000 -0400
> @@ -93,7 +93,7 @@
>      if [ "--hosts" = "$1" ]
>      then
>          shift
> -        export HADOOP_SLAVES="${HADOOP_CONF_DIR}/$$1"
> +        export HADOOP_SLAVES="${HADOOP_CONF_DIR}/$1"
>          shift
>      elif [ "--hostnames" = "$1" ]
>      then



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to