[
https://issues.apache.org/jira/browse/HADOOP-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13924065#comment-13924065
]
jay vyas commented on HADOOP-3679:
----------------------------------
yay it passed!
Thanks for the feedback [~chris.douglas] .
Anyone available for a manual review of the patch? It fixes all of the
assertion orderings that i was able to find in the above classes, which were
pulled out via grepping.
> calls to junit Assert::assertEquals invert arguments, causing misleading
> error messages, other minor improvements.
> ------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-3679
> URL: https://issues.apache.org/jira/browse/HADOOP-3679
> Project: Hadoop Common
> Issue Type: Test
> Components: test
> Reporter: Chris Douglas
> Priority: Minor
> Attachments: HADOOP-3679.2.patch, HADOOP-3679.3.patch,
> HADOOP-3679.patch
>
>
> JUnit Assert::assertEquals takes its expected and actual arguments in a
> particular order, but many unit tests invert them. The error message from a
> failed assertion can be misleading.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
