[
https://issues.apache.org/jira/browse/HADOOP-10381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13919189#comment-13919189
]
Steve Loughran commented on HADOOP-10381:
-----------------------------------------
I can see the appeal, but there's ambiguity. IS 1gb a gigabyte or a gigabit.
Similar, is 1m a minute or 1 million.
What could be tractable would be to make sure all new values include their unit
in the name, "max.bandwidth.megabits"; "timeout.seconds" & try to adopt
consistent sizes across properties (for ease of cross-referencing), as well as
having sensible units (e.g. du.reserved should be MB at least)
Maybe others have opinions on the matter
> Support unit suffix in the configuration values
> ------------------------------------------------
>
> Key: HADOOP-10381
> URL: https://issues.apache.org/jira/browse/HADOOP-10381
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 2.3.0
> Reporter: Mingjiang Shi
>
> *Background*
> Currently, most configuration values implicitly indicate the unit, for
> example:
> - {{dfs.namenode.delegation.key.update-interval}}, the unit is milliseconds,
> - {{dfs.ha.log-roll.period}}, the unit is seconds
> - {{dfs.datanode.du.reserved}}, the unit is bytes
> *This causes a few inconveniences*
> 1. When modify a configuration file, one need to refer to the document to
> find out the expected unit, convert from the human readable unit to the
> expect unit. Otherwise, wrong value may be configured.
> 2. While reviewing the configuration file, it'll take some time to figure out
> the human readable size of a large number. For example, 134217728 is
> actually 128MB
> *Proposal*
> For any space or time related configurations, it should allow include the
> unit suffix, for example:
> - space related units: 64k, 64kb, 128m, 128mb, 1g, 1gb
> - time related units: 1000ms, 1min, 60sec, 1hour
> If no unit suffix is given, the default unit for the configuration item is
> used.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
