[ 
https://issues.apache.org/jira/browse/HADOOP-10285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13915139#comment-13915139
 ] 

Arpit Agarwal commented on HADOOP-10285:
----------------------------------------

bq. I don't think it's necessary on the datanode at this point. It doesn't hurt 
to restart the datanode.
Sorry I meant this in the {{NameNodeRpcServer}} constructor.
{code}
      DFSUtil.addPBProtocol(conf, RefreshCallQueueProtocolPB.class,
          refreshCallQueueService, serviceRpcServer);
{code}
I don't think we need to accept {{refreshCallQueue}} on the 
{{serviceRpcServer}} port. We can remove this line of code.

bq. Interesting idea, I also think it would be nice to have a return status on 
the Refresh* calls too, because right now they're just void. Is that something 
we'd want done in this patch, or a separate issue to refactor 
RefreshCallQueueProto into something more generic?
We can address it in a separate Jira if it makes sense, but ideally in the same 
release so we don't have to support {{RefreshCallQueueProto}} forever.

Thanks for the quick response.

> Admin interface to swap callqueue at runtime
> --------------------------------------------
>
>                 Key: HADOOP-10285
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10285
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Chris Li
>         Attachments: HADOOP-10285.patch, HADOOP-10285.patch, 
> HADOOP-10285.patch, bisection-test.patch, bisection-test.patch, 
> bisection-test.patch, bisection-test.patch, bisection-test.patch
>
>
> We wish to swap the active call queue during runtime in order to do 
> performance tuning without restarting the namenode.
> This patch adds the ability to refresh the call queue on the namenode, 
> through dfsadmin -refreshCallQueue



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to