[
https://issues.apache.org/jira/browse/HADOOP-6746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13818727#comment-13818727
]
Hadoop QA commented on HADOOP-6746:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12613093/HADOOP-6746.2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3271//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3271//console
This message is automatically generated.
> hadoop-daemon.sh does not append to log files
> ---------------------------------------------
>
> Key: HADOOP-6746
> URL: https://issues.apache.org/jira/browse/HADOOP-6746
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.2.0
> Reporter: Travis Crawford
> Assignee: Akira AJISAKA
> Labels: script
> Attachments: HADOOP-6746.2.patch, HADOOP-6746.patch
>
>
> Looking in hadoop-daemon.sh we see the start command redirects logs to the
> log file by creating a new file. It does not append to the log.
> nohup nice -n $HADOOP_NICENESS "$HADOOP_HOME"/bin/hadoop --config
> $HADOOP_CONF_DIR $command "$@" > "$log" 2>&1 < /dev/null &
> I believe output should be appended to the log file so logrotate copytruncate
> works. Currently a large log file cannot be truncated without restarting the
> running service, which causes issues in production environments.
> The improved line would be exactly the same, except use >> to open the log
> file in append mode.
> nohup nice -n $HADOOP_NICENESS "$HADOOP_HOME"/bin/hadoop --config
> $HADOOP_CONF_DIR $command "$@" >> "$log" 2>&1 < /dev/null &
--
This message was sent by Atlassian JIRA
(v6.1#6144)
