[
https://issues.apache.org/jira/browse/HADOOP-10035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13791925#comment-13791925
]
Colin Patrick McCabe commented on HADOOP-10035:
-----------------------------------------------
Looks good overall. Since the {{DoNotCheck}} class now represents the
functions which {{FilterFileSystem}} must not implement, rather than functions
which are not checked, should it be named {{MustNotImplement}} or similar?
> Cleanup TestFilterFileSystem
> ----------------------------
>
> Key: HADOOP-10035
> URL: https://issues.apache.org/jira/browse/HADOOP-10035
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 2.1.1-beta
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HADOOP-10035.patch
>
>
> Currently TestFilterFileSystem only checks for FileSystem methods that must
> be implemented in FilterFileSystem with a list of methods that are exception
> to this rule. This jira wants to make this check stricter by adding a test
> for ensuring the methods in exception rule list must not be implemented by
> the FilterFileSystem.
> This also cleans up the current class that has methods from exception rule
> list to interface to avoid having to provide dummy implementation of the
> methods.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
