[
https://issues.apache.org/jira/browse/HADOOP-9225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13784380#comment-13784380
]
Jason Lowe commented on HADOOP-9225:
------------------------------------
Patch looks pretty good overall, but I'm confused as to how the comment raised
by [~cmccabe] was addressed. The test is trying to load the snappy library
manually which seems a bit odd, since it's making some assumptions as to how
the snappy support is supposed to be loaded. I noticed NativeLibraryChecker is
essentially checking NativeCodeLoader.isNativeCodeLoaded() &&
NativeCodeLoader.buildSupportsSnappy() && SnappyCodec.isNativeCodeLoaded() for
Snappy support, which can probably be simplified to just
SnappyCodec.isNativeCodeLoaded(). Is there a reason we shouldn't be doing the
same in this test?
> Cover package org.apache.hadoop.compress.Snappy
> -----------------------------------------------
>
> Key: HADOOP-9225
> URL: https://issues.apache.org/jira/browse/HADOOP-9225
> Project: Hadoop Common
> Issue Type: Test
> Affects Versions: 3.0.0, 2.0.3-alpha, 0.23.6
> Reporter: Vadim Bondarev
> Assignee: Vadim Bondarev
> Attachments: HADOOP-9225-branch-0.23-a.patch,
> HADOOP-9225-branch-2-a.patch, HADOOP-9225-branch-2-b.patch,
> HADOOP-9225-branch-2-c.patch, HADOOP-9225-trunk-a.patch,
> HADOOP-9225-trunk-b.patch, HADOOP-9225-trunk-c.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.1#6144)
