[
https://issues.apache.org/jira/browse/HADOOP-9527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ivan Mitic updated HADOOP-9527:
-------------------------------
Attachment: HADOOP-9527.011.patch
Thanks Arpit for addressing the latest comments.
I re-reviewed the patch and it looks good. Had some minor comments (see below)
which I went ahead and addressed in the v11 version of the patch. At this point
I am +1 on the latest patch (if you’re fine with my modifications). I’ll give
the latest patch a day before I commit, in case Chris or Chuan have something
to add.
Comments addressed in v11:
- We should reconcile FileUtil#getPathWithoutSchemeAndAuthority() with the new
Path#getPathWithoutSchemeAndAuthority API recently added
- RawLocalFileSystem#readLink is not used anymore and should be deleted
- Let’s not modify TestSymlinkHdfs, instead we can leave the base
implementation and just override as needed (otherwise, we’d have to split this
in a separate HDFS jira)
- IMO, it is better to leave
TestSymlinkLocalFsFileSystem#testRenameSymlinkToItself to fail on Windows then
to add a TODO in code. You have a tracking Jira what will suffice.
> Add symlink support to LocalFileSystem on Windows
> -------------------------------------------------
>
> Key: HADOOP-9527
> URL: https://issues.apache.org/jira/browse/HADOOP-9527
> Project: Hadoop Common
> Issue Type: Bug
> Components: test
> Affects Versions: 2.3.0
> Reporter: Arpit Agarwal
> Assignee: Arpit Agarwal
> Attachments: HADOOP-9527.001.patch, HADOOP-9527.002.patch,
> HADOOP-9527.003.patch, HADOOP-9527.004.patch, HADOOP-9527.005.patch,
> HADOOP-9527.006.patch, HADOOP-9527.007.patch, HADOOP-9527.008.patch,
> HADOOP-9527.009.patch, HADOOP-9527.010.patch, HADOOP-9527.011.patch,
> RenameLink.java
>
>
> Multiple test cases are broken. I didn't look at each failure in detail.
> The main cause of the failures appears to be that RawLocalFS.readLink() does
> not work on Windows. We need "winutils readlink" to fix the test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
