[ 
https://issues.apache.org/jira/browse/HADOOP-9652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13715668#comment-13715668
 ] 

Andrew Wang commented on HADOOP-9652:
-------------------------------------

Cool, thanks for taking a peek Chris. Just to further clarify, the v1 patch 
would have broken getFileStatus and getFileLinkStatus for local Windows 
filesystems, so I figure the v2 still makes sense even if the local Windows 
symlink tests are currently broken.

I think the v2 patch is thus ready for further review or commit (still applies 
to trunk for me). Already has a +1 from Jenkins above.
                
> RawLocalFs#getFileLinkStatus does not fill in the link owner and mode
> ---------------------------------------------------------------------
>
>                 Key: HADOOP-9652
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9652
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Colin Patrick McCabe
>            Assignee: Andrew Wang
>         Attachments: hadoop-9452-1.patch, hadoop-9652-2.patch
>
>
> {{RawLocalFs#getFileLinkStatus}} does not actually get the owner and mode of 
> the symlink, but instead uses the owner and mode of the symlink target.  If 
> the target can't be found, it fills in bogus values (the empty string and 
> FsPermission.getDefault) for these.
> Symlinks have an owner distinct from the owner of the target they point to, 
> and getFileLinkStatus ought to expose this.
> In some operating systems, symlinks can have a permission other than 0777.  
> We ought to expose this in RawLocalFilesystem and other places, although we 
> don't necessarily have to support this behavior in HDFS.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to