[ 
https://issues.apache.org/jira/browse/HADOOP-9717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13709392#comment-13709392
 ] 

Tsz Wo (Nicholas), SZE commented on HADOOP-9717:
------------------------------------------------

- Since protobuf does not have byte or int8 
(https://developers.google.com/protocol-buffers/docs/proto#scalar), how about 
using int for it in the code?

- Call Id and retry count should be set together.  Let's combine setCallId and 
setRetryCount in Client.

- Similar to Server.Call, it may be better to add retry count to Client.Call as 
a field.

- Server.getCallRetryCount() is not used.

- In TestProtoUtil, it should be INVALID_RETRY_COUNT instead of INVALID_CALL_ID.
                
> Add retry flag/retry attempt count to the RPC requests
> ------------------------------------------------------
>
>                 Key: HADOOP-9717
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9717
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Suresh Srinivas
>            Assignee: Jing Zhao
>         Attachments: HADOOP-9717.000.patch
>
>
> RetryCache lookup on server side implementation can be optimized if Rpc 
> request indicates if the request is being retried. This jira proposes adding 
> an optional field to Rpc request that indicates if request is being retried.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to