[
https://issues.apache.org/jira/browse/HADOOP-9290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13640078#comment-13640078
]
Ivan Mitic commented on HADOOP-9290:
------------------------------------
Thanks Arpit and Chris for preparing this patch! I kicked off a full test run
on Windows to validate the approach.
In parallel, I have a few questions/comments on the latest patch:
1. hadoop-project/pom.xml: It seems that the currently defined value for
LD_LIBRARY_PATH is invalid. I think it should have the following value:
{code}
<LD_LIBRARY_PATH>${env.LD_LIBRARY_PATH}:${project.build.directory}/native/target/usr/local/lib:${basedir}/../../hadoop-common-project/hadoop-common/target/bin</LD_LIBRARY_PATH>
{code}
2. hadoop-project/pom.xml: Assuming that we specified a valid value for
LD_LIBRARY_PATH above, the following section might not be needed:
{code}
<!-- Specify where to look for the native DLL on Windows -->
<PATH>${env.PATH};${basedir}/../../hadoop-common-project/hadoop-common/target/bin</PATH>
<PATH>${env.PATH};${hadoop.common.build.dir}/bin</PATH>
{code}
3. Other pom.xml files: Can we just define a new value for LD_LIBRARY_PATH next
to HADOOP_HOME and point it to the appropriate /target/bin folder in every
subproject? This would provide a nice symmetry with how we locate winutils on
Windows.
4. Might make sense to either remove hadoop.common.build.dir or use it for both
winutils.exe and hadoop.dll
> Some tests cannot load native library
> -------------------------------------
>
> Key: HADOOP-9290
> URL: https://issues.apache.org/jira/browse/HADOOP-9290
> Project: Hadoop Common
> Issue Type: Bug
> Components: build, native
> Affects Versions: 3.0.0
> Reporter: Arpit Agarwal
> Assignee: Chris Nauroth
> Attachments: HADOOP-9290.2.patch, HADOOP-9290.patch
>
>
> Some tests are unable to load the native DLL on Windows. The culprit appears
> to be an incorrect PATH configuration for the native-win profile in
> hadoop-project/pom.xml.
> {code:xml}
> <profile>
> <id>native-win</id>
> <activation>
> <os>
> <family>Windows</family>
> </os>
> </activation>
> <build>
> <plugins>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-surefire-plugin</artifactId>
> <configuration>
> <environmentVariables>
> <!-- Specify where to look for the native DLL on Windows -->
>
> <PATH>${env.PATH};${basedir}\..\..\hadoop-common-project\hadoop-common\target\bin;</PATH>
> </environmentVariables>
> </configuration>
> </plugin>
> </plugins>
> </build>
> </profile>
> {code}
> This is evaluated independently by each project and the relative path is not
> always correct.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
