[
https://issues.apache.org/jira/browse/HADOOP-9338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13592967#comment-13592967
]
Aaron T. Myers commented on HADOOP-9338:
----------------------------------------
Hi Nick, the patch looks pretty good to me. I just have three comments:
# I recommend adding a JavaDoc comment to RawLocalFileSystem#setTimes saying
explicitly that access time is not set by that method.
# In the comment for CommandWithDestination#setPreserve, I'd recommend
explicitly saying that the only attributes which the option will attempt to
preserver are modtime and atime.
# Similarly to #2 above, in the command usage text I recommend making it clear
which attributes will be preserved. This seems particularly important since the
implementation of this '-p' is not quite the same as the usual `cp -p' since
the latter will also attempt to preserve file ownership and mode. For that
matter, any reason we shouldn't make this option in the Hadoop shell attempt to
preserve all of these attributes as well?
> FsShell Copy Commands Should Optionally Preserve File Attributes
> ----------------------------------------------------------------
>
> Key: HADOOP-9338
> URL: https://issues.apache.org/jira/browse/HADOOP-9338
> Project: Hadoop Common
> Issue Type: New Feature
> Components: fs
> Affects Versions: 0.20.2, 2.0.3-alpha
> Reporter: Nick White
> Assignee: Nick White
> Attachments: HADOOP-9338.0.patch, HADOOP-9338.1.patch,
> HADOOP-9338.2.patch
>
>
> The attached patch adds a -p flag to the copyFromLocal and copyToLocal
> FsShell commands that behaves (as far as possible) like the unix 'cp'
> command's -p flag (i.e. preserves file last access and last modification
> times).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
