[
https://issues.apache.org/jira/browse/HADOOP-8924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13551542#comment-13551542
]
Alejandro Abdelnur commented on HADOOP-8924:
--------------------------------------------
patch LGTM (pending Jenkins), but somebody else should +1 as I'm partially
responsible for it.
One thing I've forgot to mention is that currently (and with this patch) MD5
are done only for the sources in common and in yarn. And the VersionInfo from
common is used in hdfs. IMO, we should either have a global MD5 & VersionInfo
for the whole project or one per module. This is out of scope of this JIRA,
just wanted to bring it up.
> Hadoop Common creating package-info.java must not depend on sh, at least for
> Windows
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-8924
> URL: https://issues.apache.org/jira/browse/HADOOP-8924
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: trunk-win
> Reporter: Chris Nauroth
> Assignee: Alejandro Abdelnur
> Fix For: trunk-win
>
> Attachments: HADOOP-8924.2.patch, HADOOP-8924.3.patch,
> HADOOP-8924.3.patch, HADOOP-8924-branch-trunk-win.2.patch,
> HADOOP-8924-branch-trunk-win.3.patch, HADOOP-8924-branch-trunk-win.patch,
> HADOOP-8924.patch
>
>
> Currently, the build process relies on saveVersion.sh to generate
> package-info.java with a version annotation. The sh binary may not be
> available on all developers' machines (e.g. Windows without Cygwin). This
> issue tracks removal of that dependency in Hadoop Common.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
