[ 
https://issues.apache.org/jira/browse/HADOOP-9066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503114#comment-13503114
 ] 

Harsh J commented on HADOOP-9066:
---------------------------------

Hi David,

A few comments.

# We accept contributions in patches (i.e. in unified diff format) made against 
trunk, not as source files. Please read the page 
http://wiki.apache.org/hadoop/HowToContribute for more details on how to 
contribute in a way that is easier to accept.
# These comparables seem useful in a utility such as the {{fs -ls}} if they are 
not already present, but maybe not so much in the core (like say MR). Can you 
instead target these comparator switches to match {{ls}} options and have {{fs 
-ls}} do the work? See class "Ls" in hadoop-common's org.apache.hadoop.fs.shell 
package for the {{fs -ls}} implementation.

Regards,
Harsh
                
> Sorting for FileStatus[]
> ------------------------
>
>                 Key: HADOOP-9066
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9066
>             Project: Hadoop Common
>          Issue Type: Improvement
>         Environment: java7 , RedHat9 , Hadoop 0.20.2 
> ,eclipse-jee-juno-linux-gtk.tar.gz
>            Reporter: david king
>              Labels: patch
>         Attachments: ConcreteFileStatusAscComparable.java, 
> ConcreteFileStatusDescComparable.java, FileStatusComparable.java, 
> FileStatusTool.java, TestFileStatusTool.java
>
>
>   I will submit a batch of FileStatusTool that used to sort FileStatus by the 
> Comparator, the Comparator not only customer to realizate , but alse use the 
> example code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to