[
https://issues.apache.org/jira/browse/HADOOP-8957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489257#comment-13489257
]
Suresh Srinivas commented on HADOOP-8957:
-----------------------------------------
Chris, some minor comments:
# Hdfs.java - no need for @see. @override takes care of ensuring that the
javadoc points to the base class. This change is needed also for FilterFs.java,
ChRootedFs,
# Hdfs.java Instead of saying "Check for ...", please be explicit in the
comment that the patterns are prohibited.
# ViewFileSystem.java - Can you describe why isValidName override and check is
removed?
Otherwise change looks good.
> FileContext.getFileContext causes multiple test failures on Windows due to
> InvocationTargetException
> ----------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8957
> URL: https://issues.apache.org/jira/browse/HADOOP-8957
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 3.0.0, trunk-win
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Attachments: HADOOP-8957.patch
>
>
> This appears to be a problem with parsing a Windows-specific path, ultimately
> throwing InvocationTargetException from AbstractFileSystem.newInstance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
