[
https://issues.apache.org/jira/browse/HADOOP-8615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485159#comment-13485159
]
Andy Isaacson commented on HADOOP-8615:
---------------------------------------
Thomas,
Thank you for working on this! I've been annoyed by this unhelpful error
message before.
The findbugs complaint seems legit:
{code}
Correctness Warnings
Code Warning
MF Field BlockDecompressorStream.fileName masks field in superclass
org.apache.hadoop.io.compress.DecompressorStream
{code}
Please fix the coding style throughout the patch:
* you have leftover unused comments like ";//" at the end of lines
* always put a space after , in argument lists, for example
{{decompress(buf,0,10);}} but there are many occurrences in the patch.
* in {{if}} tests, always put exactly space before ( and { and around
operators. For example {{if(null != this.fileName){ }} has one extra space
after {{!=}} and is missing spaces before ( and {.
* properly indent continuation lines. Use vim or emacs or eclipse for
automatic indentation if necessary.
* exactly one space around {{else}}, you have }else{ in several places.
* in {{testBlockDecompress}} you want to {{fail("did not raise expected
exception")}} after calling {{.decompress}}.
* please fill in javadoc {{\@param}} entries, or delete them.
The patch is looking good, almost all the above is just cosmetic. Again,
thanks for the code!
> EOFException in DecompressorStream.java needs to be more verbose
> ----------------------------------------------------------------
>
> Key: HADOOP-8615
> URL: https://issues.apache.org/jira/browse/HADOOP-8615
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.20.2
> Reporter: Jeff Lord
> Labels: patch
> Attachments: HADOOP-8615.patch, HADOOP-8615-release-0.20.2.patch
>
>
> In ./src/core/org/apache/hadoop/io/compress/DecompressorStream.java
> The following exception should at least pass back the file that it encounters
> this error in relation to:
> protected void getCompressedData() throws IOException {
> checkStream();
> int n = in.read(buffer, 0, buffer.length);
> if (n == -1) {
> throw new EOFException("Unexpected end of input stream");
> }
> This would help greatly to debug bad/corrupt files.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
