pan3793 commented on code in PR #8682: URL: https://github.com/apache/hadoop/pull/8682#discussion_r3811375770
########## hadoop-common-project/hadoop-common/src/test/resources/META-INF/services/org.junit.platform.launcher.TestExecutionListener: ########## @@ -0,0 +1,18 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +org.apache.hadoop.test.TimedOutTestsListener Review Comment: This descriptor never reaches the published test-jar. `hadoop-common` inherits `prepare-test-jar` from `hadoop-project-dist/pom.xml:78`, whose `<includes>` are only `**/*.class`, `webapps/**`, `META-INF/LICENSE.txt`, `META-INF/NOTICE.txt` — `META-INF/services/**` is filtered out. So `hadoop-common-*-tests.jar` has no `TestExecutionListener` registration: - In-reactor the descriptor is in `target/test-classes`, so in-tree modules with the hadoop-common test-jar get the listener (that half of the "wider net" works). - Downstream consumers (HBase, Ozone, Hive, Tez) get the `GenericTestUtils.waitFor` message change (the `.class` files ship) but no listener, so their `@Timeout` dumps silently disappear. Either add `<include>META-INF/services/**</include>` to `prepare-test-jar` or scope the PR description to in-reactor behavior. But, adding that include is exactly what makes the downstream silent-activation concern real — see comment https://github.com/apache/hadoop/pull/8682/changes#r3811369877. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
