[
https://issues.apache.org/jira/browse/HADOOP-15190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18100030#comment-18100030
]
ASF GitHub Bot commented on HADOOP-15190:
-----------------------------------------
ferdelyi commented on code in PR #8606:
URL: https://github.com/apache/hadoop/pull/8606#discussion_r3673480371
##########
hadoop-project/pom.xml:
##########
@@ -2627,6 +2618,33 @@
</excludes>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.jacoco</groupId>
+ <artifactId>jacoco-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>prepare-agent</id>
+ <goals>
+ <goal>prepare-agent</goal>
+ </goals>
+ <configuration>
+ <skip>${hadoop.skip-jacoco}</skip>
Review Comment:
@pan3793 thank you for this question. The custom hadoop.skip-jacoco was
originally meant as a single Hadoop-owned switch covering the whole coverage
feature — both the plugin executions and whether the hadoop-coverage aggregate
module joins the reactor — while leaving ad-hoc jacoco:report runs working
without a flag. But you're right that a bespoke property isn't worth it when
the plugin already exposes jacoco.skip. I've switched to jacoco.skip (default
true in the root pom so hadoop-coverage resolves it too; enable with
-Djacoco.skip=false) and dropped the now-redundant explicit <skip> elements.
The only behavior change is that coverage is now opt-in everywhere, so a bare
mvn jacoco:report is skipped unless -Djacoco.skip=false is passed.
> Use Jacoco to generate Unit Test coverage reports
> -------------------------------------------------
>
> Key: HADOOP-15190
> URL: https://issues.apache.org/jira/browse/HADOOP-15190
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Reporter: Duo Xu
> Assignee: Ferenc Erdelyi
> Priority: Minor
> Labels: pull-request-available
> Attachments: HADOOP-15190-design_2026_July_16.txt,
> HADOOP-15190.01.patch, aggregate_coverage_report_demo_2026_july_17.png,
> hadoop_nfs_jacoco_report_2026_july_17.png, jacoco_report_2018_01_25.JPG
>
>
> Currently Hadoop is using maven-clover2-plugin for code coverage, which is
> outdated. And Atlassian open-sourced clover last year so license cannot be
> purchased although we can switch to use the license-free version called
> "openclover".
> This Jira is to replace clover with Jacoco, which is actively maintained by
> the community.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
