pan3793 commented on code in PR #8621:
URL: https://github.com/apache/hadoop/pull/8621#discussion_r3672455439
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp/pom.xml:
##########
@@ -484,7 +484,14 @@
</execution>
</executions>
<configuration>
- <skipJasmineTests>${skipTests}</skipJasmineTests>
+ <!-- No explicit skipJasmineTests element: the plugin
already
+ binds skipTests, maven.test.skip and skipJasmineTests
to the
+ matching command-line properties and skips when any
is true.
+ Setting the element here would override those
bindings, so
+ -DskipJasmineTests would be ignored. Omitting it lets
+ -DskipTests skip jasmine (as before) while
-DskipJasmineTests=true
+ skips only the browser-driven specs (e.g. on a
headless box
+ with no PhantomJS) without disabling the module's
other tests. -->
Review Comment:
the words are too verbose, just say: Jasmine tests will be skipped if any
one of `-Dmaven.test.skip`, `-DskipTests`, `-DskipJasmineTests=true` is set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
