[ 
https://issues.apache.org/jira/browse/HADOOP-18896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18099977#comment-18099977
 ] 

ASF GitHub Bot commented on HADOOP-18896:
-----------------------------------------

anshuksi282-ksolves commented on PR #8622:
URL: https://github.com/apache/hadoop/pull/8622#issuecomment-5114860202

   > +1 LGTM
   
   Hi @dineshchitlangia @pjfanning, thanks for the reviews and the approval!
   
   Since the CI is completely green and the requested changes have been 
addressed, could you please help get this merged? Let me know if there is 
anything else required from my end.




> NegativeArraySizeException thrown in FSOutputSummer.java given large 
> file.bytes-per-checksum
> --------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-18896
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18896
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.3.6
>            Reporter: rstest
>            Priority: Critical
>              Labels: pull-request-available
>
> Buffer size of FSOutputSummer equals to `file.bytes-per-checksum` times 
> `BUFFER_NUM_CHUNKS`. A large `file.bytes-per-checksum` causes buffer size to 
> overflow and crash with NegativeArraySizeException.
> To reproduce:
> 1. set `file.bytes-per-checksum` to 238609295
> 2. `mvn surefire:test 
> -Dtest=org.apache.hadoop.hdfs.TestDecommissionWithStriped#testFileSmallerThanOneStripe`
> We created a PR that provides a fix which checks the buffer size is positive 
> after multiplying `file.bytes-per-checksum` with `BUFFER_NUM_CHUNKS`



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to