pan3793 commented on code in PR #8606:
URL: https://github.com/apache/hadoop/pull/8606#discussion_r3672014823
##########
hadoop-project/pom.xml:
##########
@@ -2627,6 +2618,33 @@
</excludes>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.jacoco</groupId>
+ <artifactId>jacoco-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>prepare-agent</id>
+ <goals>
+ <goal>prepare-agent</goal>
+ </goals>
+ <configuration>
+ <skip>${hadoop.skip-jacoco}</skip>
Review Comment:
the plugin already exposes a property `jacoco.skip`, why do we need a custom
one?
##########
hadoop-cloud-storage-project/hadoop-gcp/pom.xml:
##########
@@ -88,7 +88,7 @@
<forkCount>${testsThreadCount}</forkCount>
<reuseForks>false</reuseForks>
<trimStackTrace>false</trimStackTrace>
- <argLine>${maven-surefire-plugin.argLine}
-DminiClusterDedicatedDirs=true</argLine>
+ <argLine>${maven-surefire-plugin.argLine} @{argLine}
-DminiClusterDedicatedDirs=true</argLine>
Review Comment:
how does the `@{argLine}` work? I didn't find where it is defined, and who
does the replacement.
##########
BUILDING.txt:
##########
@@ -149,7 +149,18 @@ Maven build goals:
* Run checkstyle : mvn compile checkstyle:checkstyle
* Install JAR in M2 cache : mvn install
* Deploy JAR to Maven repo : mvn deploy
- * Run clover : mvn test -Pclover
+ * Run JaCoCo coverage : mvn verify -Dhadoop.skip-jacoco=false
-Dmaven.test.failure.ignore=true --fail-at-end
+ (aggregate report:
hadoop-coverage/target/site/jacoco-aggregate/index.html;
+ must be a full-reactor build, not -pl
hadoop-coverage.
+ --fail-at-end keeps the reactor
building/testing the modules
+ that don't depend on a hard-failing one (each
writing its
+ target/jacoco.exec) instead of stopping at the
first failure;
+ hadoop-coverage does not depend on the
catalog-webapp war, so
+ it still runs report-aggregate at the verify
phase.
+ -Dmaven.test.failure.ignore=true only
tolerates surefire *test*
+ failures; a plugin-level hard failure (e.g.
the catalog-webapp
+ jasmine/PhantomJS browser test in a headless
container) would
+ otherwise stop the reactor before the report
is produced.)
Review Comment:
can you move this section below? e.g., after `Special plugins: OWASP's
dependency-check:` section
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
