anshuksi282-ksolves commented on PR #8636:
URL: https://github.com/apache/hadoop/pull/8636#issuecomment-5113451923

   > I think the ticket itself is wrong, why would I run a test with some other 
config, when it isn't written for it. If the test passes doesn't logs anything 
irrelevant and behaving properly. IMO there is no need of code change here
   
   Hi @ayushtkn, fair point. The only reason for this PR is that sometimes 
developers run the entire test suite globally with Kerberos enabled. When this 
test fails during those runs, the ClassCastException hides the real error, 
which wastes debugging time.
   
   However, if we shouldn't modify individual tests for custom global configs, 
I completely agree with avoiding unnecessary code changes. Just let me know, 
and I'm happy to close the PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to