anmolanmol1234 commented on code in PR #8611:
URL: https://github.com/apache/hadoop/pull/8611#discussion_r3664882543
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsBlobClient.java:
##########
@@ -367,31 +402,66 @@ public ListResponseData listPath(final String
relativePath, final boolean recurs
url,
requestHeaders);
- op.execute(tracingContext);
- ListResponseData listResponseData = parseListPathResults(op.getResult(),
uri);
- listResponseData.setOp(op);
-
- // Perform Pending Rename Redo Operation on Atomic Rename Paths.
- // Crashed HBase log rename recovery can be done by Filesystem.listStatus.
- if (tracingContext.getOpType() == FSOperationType.LISTSTATUS
- && op.getResult() != null
- && op.getResult().getStatusCode() == HTTP_OK) {
- boolean isRenameRecovered =
retryRenameOnAtomicEntriesInListResults(tracingContext,
- listResponseData.getRenamePendingJsonPaths());
- if (isRenameRecovered) {
- LOG.debug("Retrying list operation after rename recovery.");
- // Retry the list operation to get the updated list of paths after
rename recovery.
- AbfsRestOperation retryListOp = getAbfsRestOperation(
- AbfsRestOperationType.ListBlobs,
- HTTP_METHOD_GET,
- url,
- requestHeaders);
- retryListOp.execute(tracingContext);
- listResponseData = parseListPathResults(retryListOp.getResult(), uri);
- listResponseData.setOp(retryListOp);
+ updatePhotonRequestMetric(photonRequested);
Review Comment:
Metric invariant is broken on the rename-recovery retry path.
updatePhotonRequestMetric() is called once before op.execute(), but the
rename-recovery retry issues a second ListBlobs request whose response still
goes through parseListPathResultsWithMetrics(). So PHOTON_RESPONSE_COUNT +
PHOTON_FALLBACK_COUNT can exceed PHOTON_REQUEST_COUNT. Please increment the
request counter for the retry call as well (or move the increment into a helper
used by both calls).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
