K0K0V0K commented on PR #8556:
URL: https://github.com/apache/hadoop/pull/8556#issuecomment-5067838086

   Hi @ferdelyi !  
   
   Thanks for fixing this bug!
   
   > After [HADOOP-15984](https://issues.apache.org/jira/browse/HADOOP-15984) 
made HsWebServices a singleton, the same controller instance handles requests 
for multiple applications. The instance field this.uuid would hold the UUID of 
the first application ever read. Every subsequent app's log files would fail 
validation with "UUID mismatch" and return no results — until JHS restarted.
   
   Please correct me if i am wrong but in that case every other place where the 
`this.uuid` is in used can be a potential bug right? For example line #212. 
   Can you please check can we (/should we) refactor this class to remove 
this.uuid? and maybe other class varaibles also?
   Or can we restore the original behaviour when the class was not singleton?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to