yangdong2398 commented on PR #8347: URL: https://github.com/apache/hadoop/pull/8347#issuecomment-4657614900
> > No changes required to LICENSE, LICENSE-binary, or NOTICE-binary files as dependencies are shaded and not exposed in distribution. > > this is incorrect. LICENSE/NOTICE should match the content of artifacts, if you shade a 3rd dependency into a `hadoop-foo.jar`, and the hadoop binary tarball contains `hadoop-foo.jar`, things you should do are: > > * update the hadoop-foo.jar bundled LICENSE/NOTICE files to list the 3rd dependency > * update the project LICENSE-binary/NOTICE-binary used by the hadoop binary tarball to include the 3rd dependency I updated the PR accordingly. Adds the shaded/runtime dependencies com.baidubce:bce-java-sdk:0.10.330 and joda-time:joda-time:2.3 to LICENSE-binary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
