ryukobayashi opened a new pull request, #8523:
URL: https://github.com/apache/hadoop/pull/8523

   <!--
     Thanks for sending a pull request!
       1. If this is your first time, please read our contributor guidelines: 
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
       2. Make sure your PR title starts with JIRA issue id, e.g., 
'HADOOP-17799. Your PR title ...'.
   -->
   
   ### Description of PR
   
   YARN RM can transiently report negative available resources (e.g. 
cluster_capacity - allocated goes negative due to overload or node failures). 
`DefaultAMSProcessor` now applies `Resources.componentwiseMax` with 
`Resources.none()` before setting available resources in `AllocateResponse`, 
ensuring the AM always receives a non-negative value.
   
   This is a re-implementation of YARN-11964 (reverted in #8519). The previous 
fix applied the clamp inside `Resource.castToIntSafely()`, which was too broad 
and caused a regression in `TestRLESparseResourceAllocation`. This fix applies 
the clamp at the correct layer — in `DefaultAMSProcessor` where the 
`AllocateResponse` is built.
   
   Contains content generated by Claude (Anthropic)
   
   ### How was this patch tested?
   
   - Added `TestDefaultAMSProcessor#testAvailableResourcesClampedToNonNegative` 
which uses a custom scheduler that returns a negative resource limit and 
verifies the `AllocateResponse` always contains non-negative available 
resources.
   - Existing tests pass: `TestApplicationMasterServiceCapacity`, 
`TestApplicationMasterServiceFair`, `TestApplicationMasterServiceInterceptor`, 
`TestRLESparseResourceAllocation`.
   
   ### For code changes:
   
   - [x] Does the title or this PR starts with the corresponding JIRA issue id 
(e.g. 'HADOOP-17799. Your PR title ...')?
   - [x] Object storage: have the integration tests been executed and the 
endpoint declared according to the connector-specific documentation?
   - [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [x] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, 
`NOTICE-binary` files?
   
   ### AI Tooling
   
   - [x] The PR includes the phrase "Contains content generated by Claude 
(Anthropic)"
   - [x] My use of AI contributions follows the ASF legal policy
         https://www.apache.org/legal/generative-tooling.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to