[
https://issues.apache.org/jira/browse/HADOOP-19805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18083897#comment-18083897
]
ASF GitHub Bot commented on HADOOP-19805:
-----------------------------------------
deepujain commented on PR #8305:
URL: https://github.com/apache/hadoop/pull/8305#issuecomment-4556271797
CI is green on the current head, and this one still has not had a human
review. @steveloughran @EnricoMi, when you have a moment, could you please take
a look? Happy to make any follow-up changes.
> When creating a signer, if it is Configurable, set its config
> -------------------------------------------------------------
>
> Key: HADOOP-19805
> URL: https://issues.apache.org/jira/browse/HADOOP-19805
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: 3.4.3
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Trivial
> Labels: pull-request-available
> Fix For: 3.5.0, 3.4.3
>
>
> When creating a signer for s3 (or another service), if it is Configurable,
> call setConf() on it.
> This comes from me wiring s3a up to iceberg RestCatalog; it's pretty
> convoluted to connect a signer in the sdk to its owner fs otherwise, and so
> get the configuration for that bucket. Trivial change.
> (w.r.t the old convolutedness: a v1 issue). For v2 we can create and
> configure the signer then attach it: nothing else needed!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
