dParikesit opened a new pull request, #8500: URL: https://github.com/apache/hadoop/pull/8500
### Description of PR JIRA: [HDFS-17922](https://issues.apache.org/jira/browse/HDFS-17922) In RouterAsyncClientProtocol:rename2, there is a path that returns synchronously if we have empty locations `if (locs.isEmpty)`. ``` @Override public void rename2( final String src, final String dst, final Options.Rename... options) throws IOException { ... if (locs.isEmpty()) { rbfRename.routerFedRename(src, dst, srcLocations, dstLocations); // Missing async handling return; } ... asyncApply((AsyncApplyFunction<Boolean, Boolean>) isMultiDestDirectory -> { if (isMultiDestDirectory) { ... rpcClient.invokeConcurrent(locs, method); } else { rpcClient.invokeSequential(locs, method, null, null); } }); } ``` There are other paths that behave similarly, such as msync() ``` @Override public void msync() throws IOException { rpcServer.checkOperation(NameNode.OperationCategory.READ, true); ... if (namespacesEligibleForObserverReads.isEmpty()) { asyncCompleteWith(CompletableFuture.completedFuture(null)); return; } rpcClient.invokeConcurrent(namespacesEligibleForObserverReads, method); } ``` We propose to add a patch to add `asyncComplete(null);` before the return. ### How was this patch tested? ``` mvn -am -pl hadoop-hdfs-project/hadoop-hdfs-rbf -Dtest=TestRouterAsyncFederationRename test ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
