K0K0V0K commented on code in PR #8331:
URL: https://github.com/apache/hadoop/pull/8331#discussion_r3247356650
##########
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/YARNRunner.java:
##########
@@ -503,7 +503,9 @@ private List<String> setupAMCommand(Configuration jobConf) {
}
}
- vargs.add(MRJobConfig.APPLICATION_MASTER_CLASS);
+ String amClass = jobConf.get("yarn.app.mapreduce.am",
Review Comment:
> 2. changing the constant, docs, default config file, etc... how do I do
this?
The constant should be added to **MRJobConfig.class**. As far as I know, it
does not have a corresponding default value.
If you modify **MRConfig.class**, you should also update
**mapred-default.xml** and **TaskLevelSecurityEnforcement.md**.
I think providing a proper unit test could be quite challenging, since the
class loader behavior cannot be fully tested easily. However, adding a new test
under **TestYARNRunner.class** would be nice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
