steveloughran commented on PR #8466: URL: https://github.com/apache/hadoop/pull/8466#issuecomment-4444193943
@ndimiduk i don't go near hdfs, but for you I will, especially as this is so simple production-side. Commented on the tests, which are mainly about using assertJ @charlesconnell once this is in, you'll need to backport prs to branch-3.5 (straightforward) and branch-3.4, where the junit4/5 migration adds work. Using assertJ means the only homework here is changing the import of the Test class -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
