Hean-Chhinling commented on PR #8123: URL: https://github.com/apache/hadoop/pull/8123#issuecomment-4012391663
> Will clean up the code: > > * add the jstack at container-executor.c is not a good idea, probably need a new dependent file for it > * The complexity at DiagnosticJStackService.runJStack() shall be reduced > > Beside that when testing, it works as expected Cleaned up the code. Since the container-executor is executing as privilege user and only already have other function like delete_as_user or delete_path. I think putting one function for running jstack here would not be a problem architecturally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
