Hean-Chhinling commented on code in PR #8227: URL: https://github.com/apache/hadoop/pull/8227#discussion_r2842021782
########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/jsonprovider/NMJsonProvider.java: ########## @@ -0,0 +1,88 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.yarn.server.nodemanager.webapp.jsonprovider; + +import org.apache.hadoop.yarn.server.nodemanager.webapp.dao.NMDeviceResourceInfo; +import org.apache.hadoop.yarn.server.nodemanager.webapp.dao.gpu.NMGpuResourceInfo; +import org.apache.hadoop.yarn.server.webapp.dao.ContainerLogsInfoes; +import org.eclipse.persistence.jaxb.MarshallerProperties; +import org.eclipse.persistence.jaxb.rs.MOXyJsonProvider; + +import javax.ws.rs.Consumes; +import javax.ws.rs.Produces; +import javax.ws.rs.core.MediaType; +import javax.ws.rs.core.MultivaluedMap; +import javax.ws.rs.ext.Provider; +import javax.xml.bind.JAXBException; +import javax.xml.bind.Marshaller; +import javax.xml.bind.Unmarshaller; +import java.lang.annotation.Annotation; +import java.lang.reflect.Type; + +/** + * MOXy JSON provider for NodeManager WebService. + * + * <p>This class configures a MOXy JSON provider for the NodeManager REST API endpoints. + * The endpoints should be able to provide two types of JSON responses:</p> + * <ul> + * <li> + * <b>Wrapped classes</b> – classes whose JSON representation includes a root wrapper element. + * </li> + * <li> + * <b>Unwrapped classes</b> – classes whose JSON representation omits a root wrapper element. + * </li> + * </ul> + * + * <p>This behaviour can be configured by the MarshallerProperties.JSON_INCLUDE_ROOT property. + * + * By default NodeManager REST API endpoints should include the root wrapper element in the + * responses, however there are some exceptions (e.g. ContainerLogsInfoes class) which + * was introduced to provide backward-compatibility with the Jersey 1 response format.</p> + */ +@Provider +@Produces(MediaType.APPLICATION_JSON) +@Consumes(MediaType.APPLICATION_JSON) +public class NMJsonProvider extends MOXyJsonProvider { + + private boolean isRootElementNeeded(Class<?> type) { + return !type.equals(ContainerLogsInfoes.class) Review Comment: It is really challenging for me to get a response of /resource/{resourcename} from a test cluster, seems like more than one configuration is needed for it to return nonempty -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
