manika137 commented on code in PR #8229:
URL: https://github.com/apache/hadoop/pull/8229#discussion_r2839074421
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/utils/DelegationSASGeneratorVersionJuly5.java:
##########
@@ -131,6 +131,10 @@ public String getDelegationSAS(String accountName, String
containerName, String
sr = "d";
sdd = path.equals(ROOT_PATH)? "0":
Integer.toString(StringUtils.countMatches(path, "/"));
break;
+ case SASTokenProvider.LIST_CONTAINERS_OPERATION:
+ sp = "l"; // list
+ sr = "s"; // service
Review Comment:
sr would be either be b or c. we dont have support for service (s) in
delegation SAS
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/utils/DelegationSASGeneratorVersionJuly5.java:
##########
@@ -131,6 +131,10 @@ public String getDelegationSAS(String accountName, String
containerName, String
sr = "d";
sdd = path.equals(ROOT_PATH)? "0":
Integer.toString(StringUtils.countMatches(path, "/"));
break;
+ case SASTokenProvider.LIST_CONTAINERS_OPERATION:
+ sp = "l"; // list
+ sr = "s"; // service
Review Comment:
Would need a test around this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
