LamiumAmplexicaule commented on PR #8156: URL: https://github.com/apache/hadoop/pull/8156#issuecomment-3916770172
Since the version is not specified, using the newly released v5.0.0 results in build failure due to breaking changes. ```shell $ ./start-build-env.sh ubuntu_24 $ git log --oneline -n1 56192be95af (HEAD -> trunk, origin/trunk, origin/HEAD) HDFS-17861. The mis-behavior of commitBlockSynchronization may cause standby namenode and observer namenode crash. (#8120) $ mvn package -f hadoop-yarn-project/hadoop-yarn/hadoop-yarn-csi/pom.xml ~~~ [ERROR] Failed to execute goal io.github.ascopes:protobuf-maven-plugin:5.0.0:generate (default) on project hadoop-yarn-csi: The parameters 'protoc' for goal io.github.ascopes:protobuf-maven-plugin:5.0.0:generate are missing or invalid -> [Help 1] ``` - https://github.com/ascopes/protobuf-maven-plugin/releases/tag/v5.0.0 Specifying a version earlier than v5.0.0 does not cause the build to fail. ```shell $ git diff hadoop-yarn-project/hadoop-yarn/hadoop-yarn-csi/pom.xml diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-csi/pom.xml b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-csi/pom.xml index fd780bd6963..91c96d749f6 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-csi/pom.xml +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-csi/pom.xml @@ -197,6 +197,7 @@ <plugin> <groupId>io.github.ascopes</groupId> <artifactId>protobuf-maven-plugin</artifactId> + <version>4.1.3</version> <configuration> <protocVersion>${hadoop.protobuf.version}</protocVersion> <binaryMavenPlugins> $ mvn package -f hadoop-yarn-project/hadoop-yarn/hadoop-yarn-csi/pom.xml ~~~ [INFO] BUILD SUCCESS ~~~ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
