Hean-Chhinling commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2798830291
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java:
##########
@@ -2315,6 +2315,11 @@ public static boolean isAclEnabled(Configuration conf) {
public static final String LINUX_CONTAINER_RUNTIME_PREFIX = NM_PREFIX +
"runtime.linux.";
+ /** Flag to turn on/off jstack endpoints for NodeManager. By default is True
**/
+ public static final String NM_JSTACK_ENDPOINTS_ENABLED =
+ NM_PREFIX + "jstack-endpoints.enabled";
Review Comment:
hmmm...since this configuration only control the jstack endpoints, so I
think it is better to name it jstack instead of diagnostic.
May I know why do you want to name it diagnostic-api?
It seems to general to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
