[
https://issues.apache.org/jira/browse/HADOOP-19217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18057074#comment-18057074
]
ASF GitHub Bot commented on HADOOP-19217:
-----------------------------------------
hadoop-yetus commented on PR #8063:
URL: https://github.com/apache/hadoop/pull/8063#issuecomment-3864886961
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 20m 26s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +0 :ok: | xmllint | 0m 0s | | xmllint was not available. |
| +0 :ok: | markdownlint | 0m 0s | | markdownlint was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 7 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +0 :ok: | mvndep | 12m 54s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 44m 51s | | trunk passed |
| +1 :green_heart: | compile | 17m 37s | | trunk passed with JDK
Ubuntu-21.0.10+7-Ubuntu-124.04 |
| +1 :green_heart: | compile | 18m 4s | | trunk passed with JDK
Ubuntu-17.0.18+8-Ubuntu-124.04.1 |
| +1 :green_heart: | checkstyle | 5m 57s | | trunk passed |
| +1 :green_heart: | mvnsite | 6m 16s | | trunk passed |
| +1 :green_heart: | javadoc | 4m 51s | | trunk passed with JDK
Ubuntu-21.0.10+7-Ubuntu-124.04 |
| +1 :green_heart: | javadoc | 4m 47s | | trunk passed with JDK
Ubuntu-17.0.18+8-Ubuntu-124.04.1 |
| -1 :x: | spotbugs | 1m 41s |
[/branch-spotbugs-hadoop-tools_hadoop-aws-warnings.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8063/7/artifact/out/branch-spotbugs-hadoop-tools_hadoop-aws-warnings.html)
| hadoop-tools/hadoop-aws in trunk has 2 extant spotbugs warnings. |
| +1 :green_heart: | shadedclient | 35m 36s | | branch has no errors
when building and testing our client artifacts. |
| -0 :warning: | patch | 36m 14s | | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 29s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 2s | | the patch passed |
| +1 :green_heart: | compile | 16m 54s | | the patch passed with JDK
Ubuntu-21.0.10+7-Ubuntu-124.04 |
| +1 :green_heart: | javac | 16m 54s | | the patch passed |
| +1 :green_heart: | compile | 18m 3s | | the patch passed with JDK
Ubuntu-17.0.18+8-Ubuntu-124.04.1 |
| +1 :green_heart: | javac | 18m 3s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| -0 :warning: | checkstyle | 5m 54s |
[/results-checkstyle-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8063/7/artifact/out/results-checkstyle-root.txt)
| root: The patch generated 21 new + 380 unchanged - 1 fixed = 401 total (was
381) |
| +1 :green_heart: | mvnsite | 6m 15s | | the patch passed |
| +1 :green_heart: | javadoc | 4m 45s | | the patch passed with JDK
Ubuntu-21.0.10+7-Ubuntu-124.04 |
| +1 :green_heart: | javadoc | 4m 49s | | the patch passed with JDK
Ubuntu-17.0.18+8-Ubuntu-124.04.1 |
| +1 :green_heart: | spotbugs | 11m 33s | | the patch passed |
| +1 :green_heart: | shadedclient | 34m 57s | | patch has no errors
when building and testing our client artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 23m 4s |
[/patch-unit-hadoop-common-project_hadoop-common.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8063/7/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt)
| hadoop-common in the patch passed. |
| -1 :x: | unit | 254m 37s |
[/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8063/7/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt)
| hadoop-hdfs in the patch passed. |
| +1 :green_heart: | unit | 4m 0s | | hadoop-azure in the patch
passed. |
| +1 :green_heart: | unit | 3m 51s | | hadoop-aws in the patch passed.
|
| -1 :x: | asflicense | 1m 27s |
[/results-asflicense.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8063/7/artifact/out/results-asflicense.txt)
| The patch generated 3 ASF License warnings. |
| | | 585m 21s | | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.conf.TestCommonConfigurationFields |
| | hadoop.hdfs.TestRollingUpgrade |
| | hadoop.hdfs.tools.TestDFSAdmin |
| | hadoop.fs.contract.hdfs.TestHDFSContractTrash |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.53 ServerAPI=1.53 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8063/7/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/8063 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
markdownlint |
| uname | Linux 595eeaedab00 5.15.0-164-generic #174-Ubuntu SMP Fri Nov 14
20:25:16 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 8e37b9453227d9fdd1518a2caa65be58dafc88df |
| Default Java | Ubuntu-17.0.18+8-Ubuntu-124.04.1 |
| Multi-JDK versions |
/usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.10+7-Ubuntu-124.04
/usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.18+8-Ubuntu-124.04.1 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8063/7/testReport/ |
| Max. process+thread count | 2208 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common
hadoop-hdfs-project/hadoop-hdfs hadoop-tools/hadoop-azure
hadoop-tools/hadoop-aws U: . |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8063/7/console |
| versions | git=2.43.0 maven=3.9.11 spotbugs=4.9.7 |
| Powered by | Apache Yetus 0.14.1 https://yetus.apache.org |
This message was automatically generated.
> Introduce getTrashPolicy to FileSystem API
> ------------------------------------------
>
> Key: HADOOP-19217
> URL: https://issues.apache.org/jira/browse/HADOOP-19217
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Reporter: Ivan Andika
> Priority: Major
> Labels: pull-request-available
>
> Hadoop FileSystem supports multiple FileSystem implementations awareness
> (e.g. client is aware of both hdfs:// and ofs:// protocols).
> However, it seems that currently Hadoop TrashPolicy remains the same
> regardless of the URI scheme. The TrashPolicy is governed by
> "fs.trash.classname" configuration and stays the same regardless of the
> FileSystem implementation. For example, HDFS defaults to TrashPolicyDefault
> and Ozone defaults to TrashPolicyOzone, but only one will be picked since the
> the configuration will be overwritten by the other.
> Therefore, I propose to tie the TrashPolicy implementation to each FileSystem
> implementation by introducing a new FileSystem#getTrashPolicy interface.
> TrashPolicy#getInstance can call FileSystem#getTrashPolicy to get the
> appropriate TrashPolicy.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
