dlmarion commented on code in PR #8065: URL: https://github.com/apache/hadoop/pull/8065#discussion_r2576975512
########## hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml: ########## @@ -1779,6 +1779,22 @@ </description> </property> +<property> + <name>dfs.datanode.synconclose</name> + <value>false</value> + <description> + If this property is enabled, the datanode will instruct the + operating system to sync data block files contents to disk when the + blockfile is closed. This can help data loss in the event of a malfunction such as a power + failure. + + This has the benefit of ensuring that data is written to disk + immediately when a block is closed, avoiding the data being held + solely in the operating system cache. This can help data loss in the event + of a malfunction such as a power failure. Review Comment: My previous suggestions included moving the sentence "This can help data loss in the event of a malfunction such as a power failure." from the second paragraph to the first and possibly removing the second paragraph because at the time it was inaccurate. Now the sentence is duplicated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
