[
https://issues.apache.org/jira/browse/HADOOP-19737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18039611#comment-18039611
]
ASF GitHub Bot commented on HADOOP-19737:
-----------------------------------------
anmolanmol1234 commented on code in PR #8056:
URL: https://github.com/apache/hadoop/pull/8056#discussion_r2545918450
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestAbfsInputStream.java:
##########
@@ -920,7 +920,7 @@ public void
testPrefetchReadAddsPriorityHeaderWithDifferentConfigs()
Configuration configuration2 = new Configuration(getRawConfiguration());
//use the default value for the config: false
Review Comment:
taken
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/ReadBufferManagerV2.java:
##########
@@ -1021,6 +1070,30 @@ public double getCpuLoad() {
return cpuLoad;
}
+ /**
+ * Returns the CPU utilization of the JVM process as a percentage (0–100).
+ */
+ public static double getJvmCpuUtilization() {
+ OperatingSystemMXBean osBean =
+ (OperatingSystemMXBean) ManagementFactory.getOperatingSystemMXBean();
+ long cpuTime = osBean.getProcessCpuTime();
+ long now = System.nanoTime();
+ if (lastTime == ZERO) {
+ lastCpuTime = cpuTime;
+ lastTime = now;
+ return 0.0; // first call has no previous data
Review Comment:
removed this piece of code
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestAbfsOutputStream.java:
##########
@@ -256,7 +261,7 @@ public void verifyWriteRequest() throws Exception {
*/
@Test
public void verifyWriteRequestOfBufferSizeAndClose() throws Exception {
-
+ AbfsCounters abfsCounters = Mockito.spy(new AbfsCountersImpl(new
URI("abcd")));
Review Comment:
if creating mock client handlers, client, abfsrestop, spying abfscounters is
repeated- then we could have it as a helper method maybe -> was existing code
will take it up later
> ABFS: Add metrics to identify improvements with read and write aggressiveness
> -----------------------------------------------------------------------------
>
> Key: HADOOP-19737
> URL: https://issues.apache.org/jira/browse/HADOOP-19737
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.5.0, 3.4.2
> Reporter: Anmol Asrani
> Assignee: Anmol Asrani
> Priority: Major
> Labels: pull-request-available
>
> Introduces new performance metrics in the ABFS driver to monitor and evaluate
> the effectiveness of read and write aggressiveness tuning. These metrics help
> in understanding how thread pool behavior, CPU utilization, and heap
> availability impact overall I/O throughput and latency. By capturing detailed
> statistics such as active thread count, pool size, and system resource
> utilization, this enhancement enables data-driven analysis of optimizations
> made to improve ABFS read and write performance under varying workloads.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
