[ 
https://issues.apache.org/jira/browse/HADOOP-18087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18039252#comment-18039252
 ] 

ASF GitHub Bot commented on HADOOP-18087:
-----------------------------------------

hadoop-yetus commented on PR #3935:
URL: https://github.com/apache/hadoop/pull/3935#issuecomment-3549924673

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   0m 42s |  |  Docker mode activated.  |
   |||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
   |||| _ trunk Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  22m  1s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   8m 45s |  |  trunk passed with JDK 
Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  compile  |   8m 45s |  |  trunk passed with JDK 
Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  checkstyle  |   0m 25s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   0m 27s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   0m 27s |  |  trunk passed with JDK 
Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |   0m 24s |  |  trunk passed with JDK 
Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04  |
   | -1 :x: |  spotbugs  |   0m 36s | 
[/branch-spotbugs-hadoop-common-project_hadoop-registry-warnings.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3935/5/artifact/out/branch-spotbugs-hadoop-common-project_hadoop-registry-warnings.html)
 |  hadoop-common-project/hadoop-registry in trunk has 19 extant spotbugs 
warnings.  |
   | +1 :green_heart: |  shadedclient  |  13m 59s |  |  branch has no errors 
when building and testing our client artifacts.  |
   |||| _ Patch Compile Tests _ |
   | -1 :x: |  mvninstall  |   0m 12s | 
[/patch-mvninstall-hadoop-common-project_hadoop-registry.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3935/5/artifact/out/patch-mvninstall-hadoop-common-project_hadoop-registry.txt)
 |  hadoop-registry in the patch failed.  |
   | -1 :x: |  compile  |   0m 48s | 
[/patch-compile-root-jdkUbuntu-21.0.7+6-Ubuntu-0ubuntu120.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3935/5/artifact/out/patch-compile-root-jdkUbuntu-21.0.7+6-Ubuntu-0ubuntu120.04.txt)
 |  root in the patch failed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04.  |
   | -1 :x: |  javac  |   0m 48s | 
[/patch-compile-root-jdkUbuntu-21.0.7+6-Ubuntu-0ubuntu120.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3935/5/artifact/out/patch-compile-root-jdkUbuntu-21.0.7+6-Ubuntu-0ubuntu120.04.txt)
 |  root in the patch failed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04.  |
   | -1 :x: |  compile  |   0m 50s | 
[/patch-compile-root-jdkUbuntu-17.0.15+6-Ubuntu-0ubuntu120.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3935/5/artifact/out/patch-compile-root-jdkUbuntu-17.0.15+6-Ubuntu-0ubuntu120.04.txt)
 |  root in the patch failed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04.  |
   | -1 :x: |  javac  |   0m 50s | 
[/patch-compile-root-jdkUbuntu-17.0.15+6-Ubuntu-0ubuntu120.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3935/5/artifact/out/patch-compile-root-jdkUbuntu-17.0.15+6-Ubuntu-0ubuntu120.04.txt)
 |  root in the patch failed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04.  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   0m  9s | 
[/results-checkstyle-hadoop-common-project_hadoop-registry.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3935/5/artifact/out/results-checkstyle-hadoop-common-project_hadoop-registry.txt)
 |  hadoop-common-project/hadoop-registry: The patch generated 15 new + 1 
unchanged - 0 fixed = 16 total (was 1)  |
   | -1 :x: |  mvnsite  |   0m 13s | 
[/patch-mvnsite-hadoop-common-project_hadoop-registry.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3935/5/artifact/out/patch-mvnsite-hadoop-common-project_hadoop-registry.txt)
 |  hadoop-registry in the patch failed.  |
   | -1 :x: |  javadoc  |   0m 14s | 
[/results-javadoc-javadoc-hadoop-common-project_hadoop-registry-jdkUbuntu-21.0.7+6-Ubuntu-0ubuntu120.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3935/5/artifact/out/results-javadoc-javadoc-hadoop-common-project_hadoop-registry-jdkUbuntu-21.0.7+6-Ubuntu-0ubuntu120.04.txt)
 |  
hadoop-common-project_hadoop-registry-jdkUbuntu-21.0.7+6-Ubuntu-0ubuntu120.04 
with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04 generated 5 new + 136 unchanged - 
0 fixed = 141 total (was 136)  |
   | -1 :x: |  javadoc  |   0m 12s | 
[/results-javadoc-javadoc-hadoop-common-project_hadoop-registry-jdkUbuntu-17.0.15+6-Ubuntu-0ubuntu120.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3935/5/artifact/out/results-javadoc-javadoc-hadoop-common-project_hadoop-registry-jdkUbuntu-17.0.15+6-Ubuntu-0ubuntu120.04.txt)
 |  
hadoop-common-project_hadoop-registry-jdkUbuntu-17.0.15+6-Ubuntu-0ubuntu120.04 
with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04 generated 5 new + 129 unchanged 
- 0 fixed = 134 total (was 129)  |
   | -1 :x: |  spotbugs  |   0m 12s | 
[/patch-spotbugs-hadoop-common-project_hadoop-registry.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3935/5/artifact/out/patch-spotbugs-hadoop-common-project_hadoop-registry.txt)
 |  hadoop-registry in the patch failed.  |
   | -1 :x: |  shadedclient  |   6m  9s |  |  patch has errors when building 
and testing our client artifacts.  |
   |||| _ Other Tests _ |
   | -1 :x: |  unit  |   0m 14s | 
[/patch-unit-hadoop-common-project_hadoop-registry.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3935/5/artifact/out/patch-unit-hadoop-common-project_hadoop-registry.txt)
 |  hadoop-registry in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   0m 18s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  66m 33s |  |  |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.52 ServerAPI=1.52 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3935/5/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/3935 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
   | uname | Linux 899eb9c5caf6 5.15.0-156-generic #166-Ubuntu SMP Sat Aug 9 
00:02:46 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 80e5c2a3617ae738a411855b187a8914ea53798a |
   | Default Java | Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04 |
   | Multi-JDK versions | 
/usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04 
/usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3935/5/testReport/ |
   | Max. process+thread count | 613 (vs. ulimit of 5500) |
   | modules | C: hadoop-common-project/hadoop-registry U: 
hadoop-common-project/hadoop-registry |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3935/5/console |
   | versions | git=2.25.1 maven=3.9.11 spotbugs=4.9.7 |
   | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> fix bugs when looking up record from upstream DNS servers.
> ----------------------------------------------------------
>
>                 Key: HADOOP-18087
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18087
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: registry
>    Affects Versions: 3.1.2
>            Reporter: YUBI LEE
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 3h
>  Remaining Estimate: 0h
>
> When query A record which is chained by CNAME, YARN Registry DNS Server does 
> not properly respond. Some CNAME records are missing.
> For example, "repo.maven.apache.org" is chaned as follows:
> repo.maven.apache.org.        21317   IN      CNAME   repo.apache.maven.org.
> repo.apache.maven.org.        20114   IN      CNAME   maven.map.fastly.net.
> maven.map.fastly.net. 7       IN      A       199.232.192.215
> maven.map.fastly.net. 7       IN      A       199.232.196.215
> If ask A record for "repo.maven.apache.org" using "dig" or "nslookup", YARN 
> Registry DNS Server will give answers similar to this:
> (10.1.2.3, 10.8.8.8 IP is virtual)
> {code}
> $ nslookup repo.maven.apache.org 10.1.2.3
> Server:               10.1.2.3
> Address:      10.1.2.3#53
> Non-authoritative answer:
> repo.maven.apache.org canonical name = repo.apache.maven.org.
> Name: maven.map.fastly.net
> Address: 151.101.196.215
> ** server can't find repo.apache.maven.org: NXDOMAIN
> {code}
> The reason why you can see "NXDOMAIN", "nslookup" will query "A" & "AAAA" 
> records.
> If there is no answer from other dns server, "answers == null" but YARN 
> Registry DNS Server has a bug. There is no null handling.
> {code:java}
>     // Forward lookup to primary DNS servers
>     Record[] answers = getRecords(name, type);
>     try {
>       for (Record r : answers) {
>         if (!response.findRecord(r)) {
>           if (r.getType() == Type.SOA) {
>             response.addRecord(r, Section.AUTHORITY);
>           } else {
>             response.addRecord(r, Section.ANSWER);
>           }
>         }
>         if (r.getType() == Type.CNAME) {
>           Name cname = r.getName();
>           if (iterations < 6) {
>             remoteLookup(response, cname, type, iterations + 1);
>           }
>         }
>       }
>     } catch (NullPointerException e) {
>       return Rcode.NXDOMAIN;
>     } catch (Throwable e) {
>       return Rcode.SERVFAIL;
>     }
>     return Rcode.NOERROR;
> {code}
> It should be like this:
> {code}
> nslookup repo.maven.apache.org 10.8.8.8
> Server:               10.8.8.8
> Address:      10.8.8.8#53
> Non-authoritative answer:
> repo.maven.apache.org canonical name = repo.apache.maven.org.
> repo.apache.maven.org canonical name = maven.map.fastly.net.
> Name: maven.map.fastly.net
> Address: 151.101.196.215
> {code}
> I will make a pull request at https://github.com/apache/hadoop soon.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to