[
https://issues.apache.org/jira/browse/HADOOP-19744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18039093#comment-18039093
]
ASF GitHub Bot commented on HADOOP-19744:
-----------------------------------------
hadoop-yetus commented on PR #8088:
URL: https://github.com/apache/hadoop/pull/8088#issuecomment-3546562685
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 42s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 1s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 1 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +0 :ok: | mvndep | 7m 4s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 15m 31s | | trunk passed |
| +1 :green_heart: | compile | 8m 37s | | trunk passed with JDK
Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | compile | 8m 48s | | trunk passed with JDK
Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | checkstyle | 0m 37s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 22s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 16s | | trunk passed with JDK
Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javadoc | 1m 4s | | trunk passed with JDK
Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04 |
| -1 :x: | spotbugs | 0m 36s |
[/branch-spotbugs-hadoop-common-project_hadoop-auth-warnings.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8088/1/artifact/out/branch-spotbugs-hadoop-common-project_hadoop-auth-warnings.html)
| hadoop-common-project/hadoop-auth in trunk has 8 extant spotbugs warnings.
|
| -1 :x: | spotbugs | 1m 29s |
[/branch-spotbugs-hadoop-common-project_hadoop-common-warnings.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8088/1/artifact/out/branch-spotbugs-hadoop-common-project_hadoop-common-warnings.html)
| hadoop-common-project/hadoop-common in trunk has 448 extant spotbugs
warnings. |
| +1 :green_heart: | shadedclient | 15m 6s | | branch has no errors
when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 0m 49s | | the patch passed |
| +1 :green_heart: | compile | 8m 14s | | the patch passed with JDK
Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javac | 8m 14s | | the patch passed |
| +1 :green_heart: | compile | 8m 46s | | the patch passed with JDK
Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javac | 8m 46s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| -0 :warning: | checkstyle | 0m 32s |
[/results-checkstyle-hadoop-common-project.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8088/1/artifact/out/results-checkstyle-hadoop-common-project.txt)
| hadoop-common-project: The patch generated 1 new + 5 unchanged - 0 fixed =
6 total (was 5) |
| +1 :green_heart: | mvnsite | 1m 21s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 10s | | the patch passed with JDK
Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javadoc | 1m 1s | | the patch passed with JDK
Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | spotbugs | 2m 14s | | the patch passed |
| +1 :green_heart: | shadedclient | 15m 25s | | patch has no errors
when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 50s | | hadoop-auth in the patch
passed. |
| +1 :green_heart: | unit | 15m 56s | | hadoop-common in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 32s | | The patch does not
generate ASF License warnings. |
| | | 122m 49s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.52 ServerAPI=1.52 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8088/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/8088 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | Linux 53d3e6e26ba4 5.15.0-156-generic #166-Ubuntu SMP Sat Aug 9
00:02:46 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 8944d13edc00f88f81b261b4f5d7b401f4ac2332 |
| Default Java | Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04 |
| Multi-JDK versions |
/usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
/usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8088/1/testReport/ |
| Max. process+thread count | 1300 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-auth
hadoop-common-project/hadoop-common U: hadoop-common-project |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8088/1/console |
| versions | git=2.25.1 maven=3.9.11 spotbugs=4.9.7 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
> Do not use SecurityManager in SubjectUtil.checkThreadInheritsSubject
> --------------------------------------------------------------------
>
> Key: HADOOP-19744
> URL: https://issues.apache.org/jira/browse/HADOOP-19744
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Major
>
> While the code works fine, it causes Hadoop to emit warnings
> {noformat}
> WARNING: A terminally deprecated method in java.lang.System has been called
> WARNING: System::setSecurityManager has been called by
> org.apache.hadoop.security.authentication.util.SubjectUtil
> (file:/Users/stevel/.m2/repository/org/apache/hadoop/hadoop-auth/3.5.0-SNAPSHOT/hadoop-auth-3.5.0-SNAPSHOT.jar)
> WARNING: Please consider reporting this to the maintainers of
> org.apache.hadoop.security.authentication.util.SubjectUtil
> {noformat}
> The SecurityManager check is only really needed for Java 22-23.
> We can shortcut the check by returning true for JDK21 and earlier and false
> for JDK24 and later, and only check and emit warnings for 22-23, which are
> EOL anyway.
> We can also try to duplicate the logic the JVM uses to determine whether
> SecurityManager is enabled without explicitly calling it, but that would be
> less robust than the current check.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
