[ 
https://issues.apache.org/jira/browse/HADOOP-19744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Istvan Toth updated HADOOP-19744:
---------------------------------
    Description: 
While the code works fine, it causes Hadoop to emit warnings 

{noformat}
WARNING: A terminally deprecated method in java.lang.System has been called
WARNING: System::setSecurityManager has been called by 
org.apache.hadoop.security.authentication.util.SubjectUtil 
(file:/Users/stevel/.m2/repository/org/apache/hadoop/hadoop-auth/3.5.0-SNAPSHOT/hadoop-auth-3.5.0-SNAPSHOT.jar)
WARNING: Please consider reporting this to the maintainers of 
org.apache.hadoop.security.authentication.util.SubjectUtil
{noformat}

The SecurityManager check is only really needed for Java 22-23. 

We  can shortcut the check by returning true for JDK21 and earlier and false 
for JDK24 and later, and only check and emit warnings  for 22-23, which are EOL 
anyway.

We can also try to duplicate the logic the JVM uses to determine whether 
SecurityManager is enabled without explicitly calling it, but that would be 
less robust than the current check.


  was:
While the code, it causes Hadoop to emit warnings 

{noformat}
WARNING: A terminally deprecated method in java.lang.System has been called
WARNING: System::setSecurityManager has been called by 
org.apache.hadoop.security.authentication.util.SubjectUtil 
(file:/Users/stevel/.m2/repository/org/apache/hadoop/hadoop-auth/3.5.0-SNAPSHOT/hadoop-auth-3.5.0-SNAPSHOT.jar)
WARNING: Please consider reporting this to the maintainers of 
org.apache.hadoop.security.authentication.util.SubjectUtil
{noformat}

The SecurityManager check is only really needed for Java 22-23. 

We  can shortcut the check by returning true for JDK21 and earlier and false 
for JDK24 and later, and only check and emit warnings  for 22-23, which are EOL 
anyway.

We can also try to duplicate the logic the JVM uses to determine whether 
SecurityManager is enabled without explicitly calling it, but that would be 
less robust than the current check.



> Improve SubjectUtil.checkThreadInheritsSubject
> ----------------------------------------------
>
>                 Key: HADOOP-19744
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19744
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Major
>
> While the code works fine, it causes Hadoop to emit warnings 
> {noformat}
> WARNING: A terminally deprecated method in java.lang.System has been called
> WARNING: System::setSecurityManager has been called by 
> org.apache.hadoop.security.authentication.util.SubjectUtil 
> (file:/Users/stevel/.m2/repository/org/apache/hadoop/hadoop-auth/3.5.0-SNAPSHOT/hadoop-auth-3.5.0-SNAPSHOT.jar)
> WARNING: Please consider reporting this to the maintainers of 
> org.apache.hadoop.security.authentication.util.SubjectUtil
> {noformat}
> The SecurityManager check is only really needed for Java 22-23. 
> We  can shortcut the check by returning true for JDK21 and earlier and false 
> for JDK24 and later, and only check and emit warnings  for 22-23, which are 
> EOL anyway.
> We can also try to duplicate the logic the JVM uses to determine whether 
> SecurityManager is enabled without explicitly calling it, but that would be 
> less robust than the current check.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to