steveloughran commented on code in PR #8062:
URL: https://github.com/apache/hadoop/pull/8062#discussion_r2523612315
##########
hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/SubjectUtil.java:
##########
@@ -61,6 +61,9 @@ public final class SubjectUtil {
private static final int JAVA_SPEC_VER = Math.max(8,
Integer.parseInt(System.getProperty("java.specification.version").split("\\.")[0]));
+ /**
+ * True if the current JVM copies the current JAAS subject into new threads
automatically
Review Comment:
nit: add a . to keep javadoc happy
##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/util/CombinedHostsFileReader.java:
##########
@@ -42,7 +42,7 @@
import org.apache.hadoop.classification.InterfaceAudience;
import org.apache.hadoop.classification.InterfaceStability;
import org.apache.hadoop.hdfs.protocol.DatanodeAdminProperties;
-
+import org.apache.hadoop.util.concurrent.SubjectInheritingThread;
Review Comment:
nit, leave the blank line between this and the other package.
I'm trying to keep that import diff down as its where we so often get
needless merge conflict
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/ITestS3AConcurrentOps.java:
##########
@@ -37,7 +37,7 @@
import org.apache.hadoop.fs.contract.ContractTestUtils.NanoTimer;
import org.apache.hadoop.fs.s3a.S3AFileSystem;
import org.apache.hadoop.test.tags.ScaleTest;
-
+import org.apache.hadoop.util.concurrent.SubjectInheritingThread;
Review Comment:
nit: restore the blank line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
