[ 
https://issues.apache.org/jira/browse/HADOOP-19668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18037882#comment-18037882
 ] 

ASF GitHub Bot commented on HADOOP-19668:
-----------------------------------------

steveloughran commented on PR #8061:
URL: https://github.com/apache/hadoop/pull/8061#issuecomment-3523881948

   ok, having merged it, I can see the javadocs are unhappy
   ```
    * subject restoration logic. SubjectInheritingThread provides a {@link 
work()}
    * method instead, which is wrapped and invoked by its own final {@link 
run()}
   ```
   
   you need a # in front of the work() and run() calls.
   can you just add this as a followup with the same JIRA ID? no need for a new 
one. thanks
   




> Add SubjectInheritingThread to restore pre JDK22 Subject behaviour in Threads
> -----------------------------------------------------------------------------
>
>                 Key: HADOOP-19668
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19668
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: security
>    Affects Versions: 3.5.0
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.5.0
>
>
> This is the first part of HADOOP-19574 which adds the compatibility code, and 
> fixes Daemon, but does not replace native Thread instances.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to