[
https://issues.apache.org/jira/browse/HADOOP-19740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18035662#comment-18035662
]
ASF GitHub Bot commented on HADOOP-19740:
-----------------------------------------
steveloughran opened a new pull request, #8058:
URL: https://github.com/apache/hadoop/pull/8058
* Pull out region resolution to new class RegionResolution for isolation and
testing through TestRegionResolution.
* Add new "sdk" and "ec2" mappings to hand down to SDK
* Test in ITestS3AEndpointRegion to verify that either the SDK fails to
resolve with an SDK message or it does resolve to *something* and the test
assert fails instead.
### How was this patch tested?
New tests.
* running regression test with configured endpoint.
* planning to run a test with a bucket set to "sdk" to see that the sdk
handles it through my .aws/config setting.
### For code changes:
- [ ] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
> S3A: add explicit "sdk" and "ec2" regions for region resolution through SDK
> and EC2 IAM
> ---------------------------------------------------------------------------------------
>
> Key: HADOOP-19740
> URL: https://issues.apache.org/jira/browse/HADOOP-19740
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs/s3
> Affects Versions: 3.4.2
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
>
> Add explicit regions to hand off to the sdk
> * sdk: "use the sdk chain"
> * ec2: "we are in EC2, use the local region" (this'll be done by the SDK,
> FWIW)
> empty string "" also hands off to the SDK; the warning will be removed
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
