slfan1989 commented on code in PR #8028: URL: https://github.com/apache/hadoop/pull/8028#discussion_r2492132718
########## pom.xml: ########## @@ -119,8 +119,8 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/x <maven-checkstyle-plugin.version>3.1.0</maven-checkstyle-plugin.version> <checkstyle.version>8.29</checkstyle.version> <dependency-check-maven.version>7.1.1</dependency-check-maven.version> - <spotbugs.version>4.2.2</spotbugs.version> - <spotbugs-maven-plugin.version>4.2.0</spotbugs-maven-plugin.version> + <spotbugs.version>4.8.3</spotbugs.version> Review Comment: Thank you all for the discussion! I believe what @szetszwo mentioned makes sense. Let me explain the situation: We have upgraded the JDK version in the `trunk` to `JDK 17` and `JDK 21`. Regarding the issue of `mvn site` failing to compile, this is a known issue and is unrelated to the `SpotBugs` plugin. Here’s a detailed explanation of the two issues: 1. The reason for upgrading is that `SpotBugs 4.2.0`, as indicated by `Yetus`, does not support scanning for JDK 17 and above. Therefore, we upgraded to a higher version, choosing `SpotBugs 4.9.7.` From my perspective, upgrading to `SpotBugs 4.9.7` is reasonable. Although new warning messages have appeared, I do not plan to roll back the version. Issue after upgrading to `SpotBugs 4.9.7`: Due to the introduction of new rules, new warning messages appeared during compilation. We have formulated a solution: - Temporary solution: We are filtering out these new warnings globally to mitigate the impact of the new filtering rules. You can refer to the related PR #8053. 2. mvn site compilation failure: This issue is related to our custom annotations, which we can see in the error logs. We already have a solution for this: - Referring to PR #8038. we have rewritten all the annotations under `hadoop-common-project/hadoop-annotations/src/main/java17/org/apache/hadoop/classification/tools/*` and added support for JDIFF under JDK 17. Currently, these two PRs are being followed up by HuaLong. In offline communication, HuaLong mentioned that he is currently on leave, so it may take some more time to complete. I hope this makes the situation clearer! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
