[
https://issues.apache.org/jira/browse/HADOOP-19729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18033621#comment-18033621
]
ASF GitHub Bot commented on HADOOP-19729:
-----------------------------------------
anujmodi2021 commented on code in PR #8043:
URL: https://github.com/apache/hadoop/pull/8043#discussion_r2470461231
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsApacheHttpClient.java:
##########
@@ -143,6 +173,51 @@ public HttpResponse execute(HttpRequestBase httpRequest,
return httpClient.execute(httpRequest, abfsHttpClientContext);
}
+ /**
+ * Executes the HTTP request with a deadline. If the request does not
complete
+ * within the deadline, it is aborted and an IOException is thrown.
+ *
+ * @param httpRequest HTTP request to execute.
+ * @param abfsHttpClientContext HttpClient context.
+ * @param connectTimeout Connection timeout.
+ * @param readTimeout Read timeout.
+ * @param deadlineMillis Deadline in milliseconds.
+ *
+ * @return HTTP response.
+ * @throws IOException network error or deadline exceeded.
+ */
+ public HttpResponse executeWithDeadline(HttpRequestBase httpRequest,
+ final AbfsManagedHttpClientContext abfsHttpClientContext,
+ final int connectTimeout,
+ final int readTimeout,
+ final long deadlineMillis) throws IOException {
+ RequestConfig.Builder requestConfigBuilder = RequestConfig
+ .custom()
+ .setConnectTimeout(connectTimeout)
+ .setSocketTimeout(readTimeout);
+ httpRequest.setConfig(requestConfigBuilder.build());
+ ExecutorService executor = Executors.newSingleThreadExecutor();
+ Future<HttpResponse> future = executor.submit(() ->
+ httpClient.execute(httpRequest, abfsHttpClientContext)
+ );
+
+ try {
+ return future.get(deadlineMillis, TimeUnit.MILLISECONDS);
+ } catch (TimeoutException e) {
+ /* Deadline exceeded, abort the request.
+ * This will also kill the underlying socket exception in the HttpClient.
+ * Connection will be marker stale and won't be returned back to KAC for
reuse.
Review Comment:
Taken
> ABFS: [Perf] Network Profiling of Tailing Requests and Killing Bad
> Connections Proactively
> ------------------------------------------------------------------------------------------
>
> Key: HADOOP-19729
> URL: https://issues.apache.org/jira/browse/HADOOP-19729
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.4.2
> Reporter: Anuj Modi
> Assignee: Anuj Modi
> Priority: Major
> Labels: pull-request-available
>
> It has been observed that certain requests taking more time than expected to
> complete hinders the performance of whole workload. Such requests are known
> as tailing requests. They can be taking more time due to a number of reasons
> and the prominent among them is a bad network connection. In Abfs driver we
> cache network connections and keeping such bad connections in cache and
> reusing them can be bad for perf.
> In this effort we try to identify such connections and close them so that new
> good connetions can be established and perf can be improved. There are two
> parts of this effort.
> # Identifying Tailing Requests: This involves profiling all the network
> calls and getting percentiles value optimally. By default we consider p99 as
> the tail latency and all the future requests taking more than tail latency
> will be considere as Tailing requests.
> # Proactively Killing Socket Connections: With Apache client, we can now
> kill the socket connection and fail the tailing request. Such failures will
> not be thrown back to user and retried immediately without any sleep but from
> another socket connection.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
