anmolanmol1234 commented on code in PR #7669:
URL: https://github.com/apache/hadoop/pull/7669#discussion_r2454257729
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AbfsConfiguration.java:
##########
@@ -478,6 +478,57 @@ public class AbfsConfiguration{
DefaultValue = DEFAULT_APACHE_HTTP_CLIENT_MAX_IO_EXCEPTION_RETRIES)
private int maxApacheHttpClientIoExceptionsRetries;
+ @BooleanConfigurationValidatorAnnotation(ConfigurationKey =
FS_AZURE_WRITE_DYNAMIC_THREADPOOL_ENABLEMENT,
+ DefaultValue = DEFAULT_WRITE_DYNAMIC_THREADPOOL_ENABLEMENT)
+ private boolean dynamicWriteThreadPoolEnablement;
+
+ @IntegerConfigurationValidatorAnnotation(ConfigurationKey =
FS_AZURE_WRITE_THREADPOOL_KEEP_ALIVE_TIME,
+ DefaultValue = DEFAULT_WRITE_THREADPOOL_KEEP_ALIVE_TIME)
+ private int writeThreadPoolKeepAliveTime;
+
+ @IntegerConfigurationValidatorAnnotation(ConfigurationKey =
FS_AZURE_WRITE_CPU_MONITORING_INTERVAL,
+ MinValue = MIN_WRITE_CPU_MONITORING_INTERVAL,
+ MaxValue = MAX_WRITE_CPU_MONITORING_INTERVAL,
+ DefaultValue = DEFAULT_WRITE_CPU_MONITORING_INTERVAL)
+ private int writeCpuMonitoringInterval;
+
+ @IntegerConfigurationValidatorAnnotation(ConfigurationKey =
FS_AZURE_WRITE_THREADPOOL_CORE_POOL_SIZE,
Review Comment:
This was used to determine the no. of threads to spawn for CPU monitoring
and was kept default as 1 but it would be better to always have a single thread
and hence removed this config,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
