brandonvin commented on code in PR #8048:
URL: https://github.com/apache/hadoop/pull/8048#discussion_r2453905622
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AFileSystemIsolatedClassloader.java:
##########
@@ -77,19 +109,9 @@ private void assertInNewFilesystem(Map<String, String>
confToSet, Consumer<FileS
}
}
- private Map<String, String> mapOf() {
- return new HashMap<>();
- }
-
- private Map<String, String> mapOf(String key, String value) {
- HashMap<String, String> m = new HashMap<>();
- m.put(key, value);
- return m;
- }
Review Comment:
Since I added test cases that set 2 key-value pairs, I switched to `Map.of`
instead of extending these. Not sure if there was a reason to avoid `Map.of`
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
